Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ' to \" to fix layout-features not working #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faldor20
Copy link

When running this command on my windows pc the layout-features flag is not working.

It's not like it isn't there at all, just that it seems to be interpreted as --layout-features=''.
This means that all layout features are disabled.

I was able to make the default set work by removing the flag entirely.
If i run the command as printed in the debug log, including the "--layout-features" flag it also works fine

I'm unsure if this a bug with shelljs or something I just don't understand but for whatever reason replacing the '' with "" makes it work as expected on my computer

@SolidWeb
Copy link

Thank you very much for helping me with this Windows-related issue (although I haven't tested it on different operating systems). I commented out the problematic line and the font features returned.

I hope this excellent package will receive an update soon.

@faldor20
Copy link
Author

@SolidWeb I actually ended up not using this because it had other issues and kept failing in my CICD pipeline which runs on linux (I know.. just can't win 😅)
I ended up making this and using it instead: https://github.com/faldor20/symbolswinger.
It doesn't crawl multiple pages, but it's a much simpler codebase and has far fewer dependencies and general complexity.
If you have more trouble it might be helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants