Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS Connections From Tscached to KairosDB #15

Open
ehatch90 opened this issue Oct 14, 2016 · 3 comments
Open

HTTPS Connections From Tscached to KairosDB #15

ehatch90 opened this issue Oct 14, 2016 · 3 comments

Comments

@ehatch90
Copy link

I can't find a straightforward way to get Tscached to use https connections instead of just http connections when communicating to KairosDB and Grafana. We are trying to roll this out to test in our company but we need the traffic to be https. If there is a way to configure this already can it be made more obvious? If there is no way to do this right now can it be added?

@zachm
Copy link
Owner

zachm commented Oct 24, 2016

Hi @ehatch90 , sorry for the late reply on this. It shouldn't be too hard - you'd want to patch the following locations:

  • tscached/handler_meta.py around line 44
  • tscached/utils.py around line 59

As well as making sure all the tests pass and adding new ones. Python requests supports HTTPS out of the box, and they have pretty excellent docs: http://docs.python-requests.org/en/master/

Are you comfortable making a PR yourself? I can try to add it myself, but time is kind of tight these days...

@ehatch90 ehatch90 reopened this Nov 15, 2016
@ehatch90
Copy link
Author

Sorry wrong button there. I did get the code fix figured out but I am still figuring out how to do a pull request for it.

@ehatch90
Copy link
Author

A pull request has been made #16 . Hopefully this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants