From 289f377117b0b4590b939410809cfc4a512665bc Mon Sep 17 00:00:00 2001 From: htolic Date: Tue, 1 Oct 2024 10:39:20 +0200 Subject: [PATCH 1/4] Add option to specify image pull secrets --- deploy/cert-manager-webhook-pdns/values.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/deploy/cert-manager-webhook-pdns/values.yaml b/deploy/cert-manager-webhook-pdns/values.yaml index cbc8730..48c11c8 100644 --- a/deploy/cert-manager-webhook-pdns/values.yaml +++ b/deploy/cert-manager-webhook-pdns/values.yaml @@ -17,6 +17,11 @@ image: # tag: latest pullPolicy: IfNotPresent +# -- Optional array of imagePullSecrets containing private registry credentials +## Ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ +imagePullSecrets: [] +# - name: secretName + nameOverride: "" fullnameOverride: "" From f3363c8871ae1940b9f1b6f0b23e27f4bab5853b Mon Sep 17 00:00:00 2001 From: htolic Date: Tue, 1 Oct 2024 10:42:00 +0200 Subject: [PATCH 2/4] Render imagePullSecrets when specified --- deploy/cert-manager-webhook-pdns/templates/deployment.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/deploy/cert-manager-webhook-pdns/templates/deployment.yaml b/deploy/cert-manager-webhook-pdns/templates/deployment.yaml index 6307f2d..c8f2c9e 100644 --- a/deploy/cert-manager-webhook-pdns/templates/deployment.yaml +++ b/deploy/cert-manager-webhook-pdns/templates/deployment.yaml @@ -26,6 +26,9 @@ spec: {{- with .Values.priorityClassName }} priorityClassName: {{ . | quote }} {{- end }} + {{- if .Values.imagePullSecrets }} + imagePullSecrets: {{ toYaml .Values.imagePullSecrets | nindent 6 }} + {{- end }} containers: - name: {{ .Chart.Name }} image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}" From ffa6d5582d9e3da9e76dc97bb0f0c897ae542dba Mon Sep 17 00:00:00 2001 From: htolic Date: Tue, 1 Oct 2024 10:43:02 +0200 Subject: [PATCH 3/4] Bump chart version --- deploy/cert-manager-webhook-pdns/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/cert-manager-webhook-pdns/Chart.yaml b/deploy/cert-manager-webhook-pdns/Chart.yaml index b4d146c..6a073cb 100644 --- a/deploy/cert-manager-webhook-pdns/Chart.yaml +++ b/deploy/cert-manager-webhook-pdns/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v2 name: cert-manager-webhook-pdns -version: 3.2.0 +version: 3.2.1 description: Cert Manager Webhook for PowerDNS. type: application home: https://github.com/zachomedia/cert-manager-webhook-pdns From 0f180e6fca6351f0c3b5ebdd2bba4b27f687f9c4 Mon Sep 17 00:00:00 2001 From: htolic Date: Tue, 1 Oct 2024 11:13:11 +0200 Subject: [PATCH 4/4] Indent list to follow the repo style --- deploy/cert-manager-webhook-pdns/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/cert-manager-webhook-pdns/templates/deployment.yaml b/deploy/cert-manager-webhook-pdns/templates/deployment.yaml index c8f2c9e..945459c 100644 --- a/deploy/cert-manager-webhook-pdns/templates/deployment.yaml +++ b/deploy/cert-manager-webhook-pdns/templates/deployment.yaml @@ -27,7 +27,7 @@ spec: priorityClassName: {{ . | quote }} {{- end }} {{- if .Values.imagePullSecrets }} - imagePullSecrets: {{ toYaml .Values.imagePullSecrets | nindent 6 }} + imagePullSecrets: {{ toYaml .Values.imagePullSecrets | nindent 8 }} {{- end }} containers: - name: {{ .Chart.Name }}