Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch deletion of events after transmission #159

Closed
fbrns opened this issue Nov 28, 2022 · 1 comment
Closed

Batch deletion of events after transmission #159

fbrns opened this issue Nov 28, 2022 · 1 comment
Labels
persistence everything around DB access spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)

Comments

@fbrns
Copy link
Member

fbrns commented Nov 28, 2022

When deleting events from the event-log repository after sending them out an inefficient implementation is used (successfulEvents.forEach(eventLogRepository::delete).

With a more efficient implementation using DELETE ... WHERE id IN (...) in the EventLogRepositoryImpl the implementation would become more efficient.

see #141 (comment)
@fbrns fbrns added spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) persistence everything around DB access release-21.0 issues/PRs planned for the next major release labels Nov 28, 2022
@fbrns fbrns mentioned this issue Nov 28, 2022
Merged
@ePaul ePaul mentioned this issue Dec 7, 2022
Closed
@ePaul ePaul removed the release-21.0 issues/PRs planned for the next major release label Dec 21, 2022
@ePaul
Copy link
Member

ePaul commented Aug 15, 2023

Implemented in #171 (without even noticing this ticket was open).

@ePaul ePaul closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
persistence everything around DB access spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ePaul @fbrns