Show Us What Didn't Match When Comparing StatefulSet Updates

[nategoethel]

Please, answer some short questions which should help us to understand your problem / question better?

• Which image of the operator are you using? v1.9.0
• Where do you run it - cloud or metal? Kubernetes or OpenShift? EKS
• Are you running Postgres Operator in production? yes
• Type of issue? Bug/Feature

Some general remarks when posting a bug report:

• Please, check the operator, pod (Patroni) and postgresql logs first. When copy-pasting many log lines please do it in a separate GitHub gist together with your Postgres CRD and configuration manifest.
• If you feel this issue might be more related to the Spilo docker image or Patroni, consider opening issues in the respective repos.

Actual Issue Writeup

The Operator is refusing to update my statefulset because it claims there are new labels being introduced. That line comes from this code:

postgres-operator/pkg/cluster/cluster.go

Lines 503 to 514 in c25dc57

	if (c.Statefulset.Spec.Selector != nil) && (statefulSet.Spec.Selector != nil) {
	if !reflect.DeepEqual(c.Statefulset.Spec.Selector.MatchLabels, statefulSet.Spec.Selector.MatchLabels) {
	// forbid introducing new labels in the selector on the new statefulset, as it would cripple replacements
	// due to the fact that the new statefulset won't be able to pick up old pods with non-matching labels.
	if !util.MapContains(c.Statefulset.Spec.Selector.MatchLabels, statefulSet.Spec.Selector.MatchLabels) {
	c.logger.Warningf("new statefulset introduces extra labels in the label selector, cannot continue")
	return &compareStatefulsetResult{}
	}
	needsReplace = true
	reasons = append(reasons, "new statefulset's selector does not match the current one")
	}
	}

However, there's nothing here that indicates what, specifically, has changed, so I don't know how to correct the issue. It would be helpful to log what labels are new in this case.