Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart CRD out-of-sync in 1.13.0 #2788

Open
bo0ts opened this issue Oct 21, 2024 · 1 comment
Open

chart CRD out-of-sync in 1.13.0 #2788

bo0ts opened this issue Oct 21, 2024 · 1 comment
Labels

Comments

@bo0ts
Copy link

bo0ts commented Oct 21, 2024

  • Which image of the operator are you using? ghcr.io/zalando/postgres-operator:v1.13.0
  • Where do you run it - cloud or metal? Kubernetes or OpenShift? OpenShift
  • Are you running Postgres Operator in production? yes
  • Type of issue? bug report

After upgrading to 1.13.0 to CRD in the chart is out-of-sync with the one installed through the helm chart.

Helm Chart:

# charts/postgres-operator/crds/postgresql.yaml
              maintenanceWindows:
                type: array
                items:
                  type: string
                  pattern: '^\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))-((2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))\ *$'

Installed in the cluster:

# pkg/apis/acid.zalan.do/v1/crds.go
					"maintenanceWindows": {
						Type: "array",
						Items: &apiextv1.JSONSchemaPropsOrArray{
							Schema: &apiextv1.JSONSchemaProps{
								Type:    "string",
								Pattern: "^\\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))-((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))\\ *$",
							},
						},
					},
@FxKu
Copy link
Member

FxKu commented Nov 26, 2024

You're right. The go.code was forgotten in #2731. In general, you can set enable_crd_registration to false to avoid that the operator overrides the deployed CRD. I guess, we should set it to false by default for the helm chart.

@FxKu FxKu added the bug label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants