From 1f101aba1b60fcbfe4b1039fa7a8250cfbac8f20 Mon Sep 17 00:00:00 2001 From: Benoit Chevallier-Mames Date: Wed, 2 Oct 2024 13:02:50 +0200 Subject: [PATCH] fix(ci): to be re-inserted, temp CI test --- .github/workflows/concrete_python_test_macos.yml | 14 +++++++++----- frontends/concrete-python/Makefile | 4 ++-- .../concrete-python/tests/execution/test_matmul.py | 2 +- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/workflows/concrete_python_test_macos.yml b/.github/workflows/concrete_python_test_macos.yml index 540fd28254..5b7691aa16 100644 --- a/.github/workflows/concrete_python_test_macos.yml +++ b/.github/workflows/concrete_python_test_macos.yml @@ -118,17 +118,21 @@ jobs: cp $GITHUB_WORKSPACE/frontends/concrete-python/Makefile . - - name: Test - run: | + # - name: Test + # run: | - set -e - cd $TEST_TMP_DIR && . .testenv/bin/activate - KEY_CACHE_DIRECTORY=./KeySetCache PYTEST_MARKERS="not dataflow and not graphviz" make pytest-macos + # set -e + # cd $TEST_TMP_DIR && . .testenv/bin/activate + # KEY_CACHE_DIRECTORY=./KeySetCache PYTEST_MARKERS="not dataflow and not graphviz" make pytest-macos - name: Test notebooks run: | set -e cd $TEST_TMP_DIR && . .testenv/bin/activate + pwd + ls + ls ./scripts + ls ./scripts/jupyter make test-notebooks-macos - name: Cleanup host diff --git a/frontends/concrete-python/Makefile b/frontends/concrete-python/Makefile index fc71764508..d0cd93c468 100644 --- a/frontends/concrete-python/Makefile +++ b/frontends/concrete-python/Makefile @@ -143,10 +143,10 @@ process-benchmark-results-for-grafana: test-notebooks: eval $(shell make silent_cp_activate) - ./scripts/jupyter/jupyter.sh + bash ./scripts/jupyter/jupyter.sh test-notebooks-macos: - ./scripts/jupyter/jupyter.sh + bash ./scripts/jupyter/jupyter.sh # ========== # Formatting diff --git a/frontends/concrete-python/tests/execution/test_matmul.py b/frontends/concrete-python/tests/execution/test_matmul.py index 96beb98a5f..58ba560326 100644 --- a/frontends/concrete-python/tests/execution/test_matmul.py +++ b/frontends/concrete-python/tests/execution/test_matmul.py @@ -337,7 +337,7 @@ def test_zero_matmul(bit_width, signed, helpers): Test matmul where one of the operators is all zeros. """ - # FIXME: it fails + # FIXME: https://github.com/zama-ai/concrete-internal/issues/879 is_mac = platform.system() == "Darwin" if is_mac and (bit_width, signed) == (10, False):