Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctness test fails for unchecked_min_or_max for radix calculations. #1801

Open
Tuditi opened this issue Nov 20, 2024 · 0 comments
Open

Correctness test fails for unchecked_min_or_max for radix calculations. #1801

Tuditi opened this issue Nov 20, 2024 · 0 comments
Labels
triage_required

Comments

@Tuditi
Copy link

Tuditi commented Nov 20, 2024

Describe the bug

The correctness test for test_default_minmax fails, which was discovered through PR: #1800.

To Reproduce
Steps to reproduce the behaviour

  1. Branch to Tuditi:fix/degree-for-min-max
  2. Run make test_integer
  3. Observe that the test fails on the correctness test

Expected behaviour
Test passes. Without setting the new degree, it would fail on the assertion of the empty carries.

Additional context
Draft PR opened in #1800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage_required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tuditi