Add dashboard template refinements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
commented
May 21, 2024
danilo-leal
commented
- I have followed (at least) the PR section of the contributing guide.
danilo-leal
changed the title
1 task
noraleonte
approved these changes
May 22, 2024
docs/data/material/getting-started/templates/dashboard/components/CustomizedTreeView.tsx
Show resolved
Hide resolved
docs/data/material/getting-started/templates/dashboard/components/HighlightedCard.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/dashboard/components/MenuButton.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/dashboard/getDashboardTheme.tsx
Show resolved
Hide resolved
…-refinements Signed-off-by: Danilo Leal <[email protected]>
zanivan
approved these changes
May 28, 2024
There was a problem hiding this comment.
Thanks @danilo-leal for such great improvements overall!
—-
One thing, though, I think we should decide upon which chart we're going to use, bars or lines (or maybe both, but changing title/legend labels?) What do you think @noraleonte @danilo-leal ?
zanivan
merged commit 69dd35e
into
zanivan:material-ui-template-dashbaord
4 checks passed
|
@zanivan Tbh, I'm fine with either 🙈 Jun suggested line charts on twitter so we can go with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.