Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle settings are confusing/not working as intended #603

Open
Yasand123 opened this issue Apr 12, 2023 · 11 comments
Open

Subtitle settings are confusing/not working as intended #603

Yasand123 opened this issue Apr 12, 2023 · 11 comments

Comments

@Yasand123
Copy link

Hello!

I have been messing with the subtitle settings for the last couple days but for some reason it's not working as one would expect and/or it's somewhat bugged? I will list the issues separately so it's easier to follow/reference.

A) Font size for subtitles is not consistent across different videos, if Fonts and spacing is checked

If I wanted to change the fonttype (ex. from default to Tahoma) I pick it from the drop-down menu at the very top, and check both Apply for ASS/SSA subtitles and Fonts and spacing.

While it affects the font type, this makes the subtitles way too small, so I increase the font size at the top to around 90. This works nicely for that specific video, but in other videos the subtitles would be way too large at the same font size. So I either get too large or too small depending on the video, and I'd have to keep changing it in the settings.

What's the difference between these videos? Well, there are 2 possibilities, first, embedded vs external, I noticed embedded subtitles would look too small at 30 for example, while external ones look just fine.
Another possibility is the file type, embedded subs are usually ssa, while external ones ass. I doubt this is the issue however, since I tried one external ssa file after converting it.

A way to get around this is to de-couple "size" and "font type" so size would have its own checkbox.Fonts and spacing should not include font the size setting imo.

However, some might want to change the size as well, so fixing the core issue is needed here.

B) If Margin and alignment is checked, text on signs, episodes titles, etc, are moved to the bottom

These aren't dialogue subtitles, they're purposefully not at the bottom. These are usually on top of the original text on street signs, or next to the episode title.

This setting if checked turns these into regular subtitles. I think what happens here is that when the setting is checked QMPlay2 does 2 things, first reset the position and 2nd apply the new values. So that means even these are reset into the position of regular dialogue subtitles.

Maybe there's a way to exclude these? I don't know. But mpv somehow does it. Perhaps there's a specific flag in the subtitle file for these? Maybe if the subtitle line has a custom position that usually means you shouldn't mess with it? It's an interesting problem but I think the idea of making an exception for these lines is a good start.

C) Finally, this is more of a feature request, missing "Bold" option

This is needed because not all fonts have bold variant that is selectable from menus

I apologize if this is long, but I wanted to include details as they might be useful in debugging.
Thank you for your time, and for this awesome media player!

@zaps166
Copy link
Owner

zaps166 commented Apr 12, 2023

Do you apply everything to ASS subtitles only? It's mostly for SRT and other simple formats. ASS has their own style, QMPlay2 can override some of them, but not all. Overridden ASS styles will not display as in style.

There's too much text without examples 😅 I need sample file and settings which doesn't work (I don't use "Apply for ASS/SSA subtitles" because it's pointless for most ASS subs).

@Rtizer-9
Copy link

@zaps166 Hi, I'm experiencing a similar issue where the sizing modifications in qmplay2 hardly affects the actual size and it's a normal sub file embedded in the movie I'm watching right now not an ass or some other pgssub.

I can confirm that subtitles can indeed be resized because smplayer is able to do so with the same video.

The rendering/decoding and hardware acceleration is far better than mpv/smplayer but this one particular issue is nagging me since I already have a small size laptop screen and those subtitles take huge space.

@zaps166
Copy link
Owner

zaps166 commented Nov 19, 2024

Hmm, tested it briefly now with regular subtitles. Idk what spacing is doing (don't remember, can't see any difference). When changing alignment I have to restart video to apply on all texts.


Could you upload screenshot what's exactly wrong? Do you use Shift+R / Shift+T to scale subtitles without touching these settings?

@Rtizer-9
Copy link

It's a simple case of Shift-R/Shift-T not working at all.

@zaps166
Copy link
Owner

zaps166 commented Nov 19, 2024

If Shift+R / Shift+T doesn't work, it means your subtitles are bitmap subtitles (pgssub, dvdsub, etc.) - settings from "Subtitles" tab doesn't apply there.

it's a normal sub file embedded in the movie I'm watching right now not an ass or some other pgssub.

Hmm, could you put screenshot of Information panel (at least Subtitles streams)?

@Rtizer-9
Copy link

Rtizer-9 commented Nov 19, 2024

The information panel shows "sub" not pgs or dvdsub. And the resizing works perfectly in Smplayer. I'm half asleep and it's late here. I'll upload whatever information you want in the morning.

@zaps166
Copy link
Owner

zaps166 commented Nov 19, 2024

I can see names: jacosub, xsub, dvbsub, pgssub, mpsub when grepping FFmpeg code, can't find just sub codec name...

I'll upload whatever information you want in the morning.

Ok! Also if possible - URL where can I download sample file (can be send via email).

@Rtizer-9
Copy link

Information panel doesn't show just "sub", it's showing "dvdsub", I probably wrote what I saw in some other player in sleep. I've sent you more file information in email along with a sample.

Here's the mediainfo:

Format                                   : Matroska
Format version                           : Version 4
File size                                : 7.05 GiB
Duration                                 : 2 h 22 min
Overall bit rate                         : 7 080 kb/s
Frame rate                               : 23.976 FPS
Encoded date                             : 2021-02-08 10:37:35 UTC
Writing application                      : mkvmerge v38.0.0 ('The Silent Type') 64-bit
Writing library                          : libebml v1.3.9 + libmatroska v1.5.2

Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : Main 10@L4@Main
Codec ID                                 : V_MPEGH/ISO/HEVC
Duration                                 : 2 h 22 min
Bit rate                                 : 7 000 kb/s
Width                                    : 1 920 pixels
Height                                   : 1 040 pixels
Display aspect ratio                     : 1.85:1
Frame rate mode                          : Constant
Frame rate                               : 23.976 (24000/1001) FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 10 bits
Bits/(Pixel*Frame)                       : 0.146
Stream size                              : 6.97 GiB (99%)
Writing library                          : x265M - 3.4+35-772bb4c84:[Windows][GCC 10.2.0][64 bit] 10bit
Encoding settings                        : cpuid=1111039 / frame-threads=3 / numa-pools=8 / wpp / no-pmode / no-pme / no-psnr / no-ssim / log-level=2 / input-csp=1 / input-res=1920x1040 / interlace=0 / total-frames=205128 / level-idc=0 / high-tier=1 / uhd-bd=0 / ref=4 / no-allow-non-conformance / no-repeat-headers / annexb / no-aud / no-hrd / info / hash=0 / no-temporal-layers / open-gop / min-keyint=23 / keyint=250 / gop-lookahead=0 / bframes=8 / b-adapt=2 / b-pyramid / bframe-bias=0 / rc-lookahead=25 / lookahead-slices=4 / scenecut=40 / hist-scenecut=0 / radl=0 / no-splice / no-intra-refresh / ctu=64 / min-cu-size=8 / rect / no-amp / max-tu-size=32 / tu-inter-depth=1 / tu-intra-depth=1 / limit-tu=0 / rdoq-level=2 / dynamic-rd=0.00 / no-ssim-rd / signhide / no-tskip / nr-intra=0 / nr-inter=0 / no-constrained-intra / strong-intra-smoothing / max-merge=3 / limit-refs=3 / limit-modes / me=3 / subme=3 / merange=57 / temporal-mvp / no-frame-dup / no-hme / weightp / no-weightb / no-analyze-src-pics / deblock=0:0 / no-sao / no-sao-non-deblock / rd=4 / selective-sao=0 / no-early-skip / rskip / no-fast-intra / no-tskip-fast / no-cu-lossless / no-b-intra / no-splitrd-skip / rdpenalty=0 / psy-rd=2.00 / psy-rdoq=1.00 / no-rd-refine / no-lossless / cbqpoffs=0 / crqpoffs=0 / rc=abr / bitrate=7000 / qcomp=0.60 / qpstep=4 / stats-write=0 / stats-read=2 / cplxblur=20.0 / qblur=0.5 / ipratio=1.40 / pbratio=1.30 / aq-mode=3 / aq-strength=1.00 / cutree / zone-count=0 / no-strict-cbr / qg-size=32 / no-rc-grain / qpmax=69 / qpmin=0 / no-const-vbv / sar=0 / overscan=0 / videoformat=5 / range=0 / colorprim=2 / transfer=2 / colormatrix=2 / chromaloc=0 / display-window=0 / cll=0,0 / min-luma=0 / max-luma=1023 / log2-max-poc-lsb=8 / vui-timing-info / vui-hrd-info / slices=1 / no-opt-qp-pps / no-opt-ref-list-length-pps / multi-pass-opt-rps / scenecut-bias=0.05 / hist-threshold=0.03 / no-opt-cu-delta-qp / aq-motion / no-hdr10 / no-hdr10-opt / no-dhdr10-opt / no-idr-recovery-sei / analysis-reuse-level=0 / analysis-save-reuse-level=0 / analysis-load-reuse-level=0 / scale-factor=0 / refine-intra=0 / refine-inter=0 / refine-mv=1 / refine-ctu-distortion=0 / no-limit-sao / ctu-info=0 / no-lowpass-dct / refine-analysis-type=0 / copy-pic=1 / max-ausize-factor=1.0 / no-dynamic-refine / no-single-sei / no-hevc-aq / no-svt / no-field / qp-adaptation-range=1.00 / scenecut-aware-qp=0conformance-window-offsets / right=0 / bottom=0 / decoder-max-rate=0 / no-vbv-live-multi-pass
Default                                  : Yes
Forced                                   : No

Audio
ID                                       : 2
Format                                   : AAC LC
Format/Info                              : Advanced Audio Codec Low Complexity
Codec ID                                 : A_AAC-2
Duration                                 : 2 h 22 min
Bit rate                                 : 72.0 kb/s
Channel(s)                               : 1 channel
Channel layout                           : M
Sampling rate                            : 48.0 kHz
Frame rate                               : 46.875 FPS (1024 SPF)
Compression mode                         : Lossy
Delay relative to video                  : 20 ms
Stream size                              : 74.8 MiB (1%)
Language                                 : English
Default                                  : Yes
Forced                                   : No

Text
ID                                       : 3
Format                                   : VobSub
Muxing mode                              : zlib
Codec ID                                 : S_VOBSUB
Codec ID/Info                            : Picture based subtitle format used on DVDs
Duration                                 : 2 h 21 min
Bit rate                                 : 6 924 b/s
Frame rate                               : 0.139 FPS
Count of elements                        : 1179
Stream size                              : 7.00 MiB (0%)
Language                                 : English
Default                                  : No
Forced                                   : No

@zaps166
Copy link
Owner

zaps166 commented Nov 20, 2024

Well, dvdsub are not text subtitles, they're bitmap subtitles. Scaling is not supported, so it's rather a feature request.

@Rtizer-9
Copy link

Oops my bad. Ok

@zaps166
Copy link
Owner

zaps166 commented Nov 20, 2024

They are scaling with video only, so need to handle scaling subtitles, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants