Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spacing of terminal font #11744

Open
1 task done
LoricAndre opened this issue May 13, 2024 · 16 comments
Open
1 task done

Incorrect spacing of terminal font #11744

LoricAndre opened this issue May 13, 2024 · 16 comments
Labels
bug [core label] font Font feedback for readability, size, style, etc terminal Feedback for terminal integration, shell commands, etc

Comments

@LoricAndre
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I have issues with the font rendering in Zed's terminal : The characters seem to be 'grouped' 5 by 5, with an added space every 5 characters.

The font used here is JetBrains Mono Nerd Font, but the same happens with every monospace font I've tried, including the default one.

I anyone else having this issue ?

Shell: zsh
Prompt: starship

Environment

Zed: v1.0.0 (Zed Dev c90263d)
OS: Linux 1.0.0
Memory: 15.2 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

image

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@LoricAndre LoricAndre added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels May 13, 2024
@JosephTLyons JosephTLyons added terminal Feedback for terminal integration, shell commands, etc font Font feedback for readability, size, style, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 15, 2024
@lemeb
Copy link

lemeb commented Jun 6, 2024

Can confirm here, it's very weird. Take these:

Screenshot 2024-06-06 at 15 37 12

Screenshot 2024-06-06 at 15 36 31

Look, for example, at the space between "9" and "0": it changes dramatically from line to line -- even from font size to font size. (I'm using Menlo on MacOS here, but it's the same for every font).

What I'm finding, btw, is a little different that @LoricAndre: the blank is not happening every 5 spaces, but more randomly. See these screenshots:

Screenshot 2024-06-06 at 15 41 40 Screenshot 2024-06-06 at 15 42 11

Different fonts also produce different blank space results.

I love Zed so far, but this is pretty annoying to the eye...

Thanks :)

@forGGe
Copy link

forGGe commented Jul 11, 2024

I can see the same behaviour in the editor. The weird grouping depends on the font size and type. For bunch of fonts I've tried there is always a size when this artifact is gone

This is the default font size 14:

image

...and the size 15:

image

Also I'm experiencing an issue with blurred fonts, same as in #7992

Maybe it's all related.

@sadmac7000
Copy link

I've noticed this too. I'll add that the spacing between lines is much worse for me.

Here's output from a maze generator I wrote in the vscode terminal:
Screenshot from 2024-07-20 04-36-54

And here's the same program run in Zed:
Screenshot from 2024-07-20 04-37-05

These are characters from the unicode block for drawing terminal line art. They're always supposed to connect up. I haven't tried a curses app yet but I imagine it would look very strange.

@SomeoneToIgnore
Copy link
Contributor

#15503 (comment) hints there could be a way to fix this?
Worth a try at least.

@sadmac7000
Copy link

Screenshot from 2024-07-31 04-29-26

Not perfect, but better!

@LoricAndre
Copy link
Author

I already had it enabled 😞

@austinorth
Copy link

Screenshot 2024-08-14 at 9 58 30 AM
The ends of my Starship Powerline theme are suffering from this issue as well, I believe. Hack Nerd Font.

@lego-eden
Copy link

I have this issue as well on linux.

@EmeraldMastaMC
Copy link

EmeraldMastaMC commented Oct 1, 2024

Screenshot From 2024-10-01 10-28-59
I have the same problem, the prompt seems blocky. On linux here

@ahmet-cetinkaya
Copy link

Same issue
image

@swolfenden9
Copy link

Same issue here (MacOS, p10k)
image

@wesharper
Copy link

wesharper commented Oct 22, 2024

I added the following to my settings.json per the referenced issue and it resolved my issues with starship rendering:

  "terminal": {
    "line_height": "standard"
  }

@ahmet-cetinkaya
Copy link

I added the following to my settings.json per the referenced issue and it resolved my issues with starship rendering:

  "terminal": {
    "line_height": "standard"
  }

Thanks, that's works.

@ddembo
Copy link

ddembo commented Oct 23, 2024

I added the following to my settings.json per the referenced issue and it resolved my issues with starship rendering:

  "terminal": {
    "line_height": "standard"
  }

Does not resolve issue with Powerline 10k, multiple 'nerd' family fonts + Fira Code tested.

@github-actions github-actions bot added admin read Pending admin review triage Maintainer needs to classify the issue labels Nov 5, 2024
@notpeter notpeter removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 5, 2024
@awedpotato767
Copy link

20241213_16h48m16s_grim
20241213_16h48m44s_grim
Similar thing happenning to my terminal window.
In addition (may be unrelated) the gradient characters seem to be reverting back to the standard ascii implementation as opposed to the ones provided by my fonts.
(using arch linux/nvidia and a working install of meslo LGS Nerd font. same issue occurs with any other font to my knowledge.)

For context, here is a screenshot from foot (my preferred terminal emulator) using the same font.
20241213_16h50m32s_grim

@chmousset
Copy link

Similar issue here on Linux (Manjaro KDE, Wayland session with sddm, Powerline 10k, Noto & Nert fonts)
image

With "line_height": "standard" it's a bit better, but still not perfect.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] font Font feedback for readability, size, style, etc terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests