Add a setting to sync the sizes of panels in a dock #19015
Conversation
cla-bot
bot
added
the
cla-signed
|
this also bothered me quite a lot 😅 looking forward to see this merged, thanks! |
maxdeviant
changed the title
assets/settings/default.json
Outdated
| @@ -84,6 +84,9 @@ | |||
| // workspace when the centered layout is used. | |||
| "right_padding": 0.2 | |||
| }, | |||
| // Whether to sync the sizes of panels a dock. This setting takes in a list of dock positions. | |||
| // Note that this setting cannot sync size between docks. | |||
| "sync_dock_size": [], | |||
There was a problem hiding this comment.
I think we need a different name for this setting, as it sounds like it syncs the sizes of all panels across docks.
There was a problem hiding this comment.
Agree, but I can't think of a better name right now.
There was a problem hiding this comment.
sync_panel_sizes? I actually used this name first, but I changed it later because I think it has some ambiguity.
There was a problem hiding this comment.
what about consistent_dock_sizing?
Signed-off-by: Aaron Ruan <[email protected]>
Fix some typos in the comments Signed-off-by: Aaron Ruan <[email protected]>
Aaron-212
force-pushed
the
sync_dock_size
branch
from
1fc0613 to
9faa538
Compare
|
@maxdeviant could you consider review this please? |
|
Could we get this merged? 😄 |
|
Going to close this out, for now, as I think we still need to find a more natural way of expressing this setting. Is there prior art in this space? |
darn, I was curious what was the progress on this one and I've just realized it was closed without merging :( about prior art... vscode, xcode, fleet and others by design behave like this, because panels are not standalone, but they spawn inside a "container", so the sizing is always constant on those editors, they do not have a setting to toggle this behaviour though @maxdeviant is the problem just how this setting will be called? or do you oppose to the idea of having this as a zed feature? |
i wanna chime in and say that this is the default behavior on almost all apps, not just code editors, and that zed is the odd one out here. maybe this could be an opportunity to fix the problem itself instead of adding an optional setting to solve it? |
|
@nervenes perhaps it's more common but not sure I'd consider zed the outlier, intellij based ides, which are extremely popular also have independently sized panels, and I know a bunch of people who prefer that, because it's true that a panel like the file explorer doesn't benefit from all the width that the chat panel would it would be a shame to lose the flexibility of being able to choose between these two modes, especially if the code to achieve it is kinda small (as it seems to be the case here) |
Closes #12667
Release Notes:
2024-10-10.19.09.36.mov