Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FIle not working in Zed File Explorer #22598

Closed
1 task done
AlJohri opened this issue Jan 3, 2025 · 6 comments
Closed
1 task done

Rename FIle not working in Zed File Explorer #22598

AlJohri opened this issue Jan 3, 2025 · 6 comments
Labels
bug [core label] git Git integration feedback project panel Feedback for files tree view

Comments

@AlJohri
Copy link

AlJohri commented Jan 3, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I opened Zed using remote SSH for myhost at the folder Folder like so:

zed ssh://myhost/my/path/to/Folder

And now I rename a file and the UI in the sidebar shows its renamed, but the file doesn't actually get renamed.

Zed Version and System Specs

Zed: v0.166.1 (Zed)
OS: macOS 15.2.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

Screen.Recording.2025-01-02.at.8.55.54.PM.mov

If applicable, attach your Zed.log file to this issue.

Here are some relevant logs in ~/Library/Logs/Zed/Zed.log:

❯ tail -n 10  ~/Library/Logs/Zed/Zed.log  | grep "[ERROR]"
2025-01-02T20:56:20.748962-05:00 [ERROR] (remote server) server:unhandled ssh message name:RenameProjectEntry
2025-01-02T20:56:35.032677-05:00 [ERROR] (remote server) server:unhandled ssh message name:RenameProjectEntry
2025-01-02T20:56:48.868212-05:00 [ERROR] (remote server) server:error handling message. type:GetStagedText, error:buffer has no file
2025-01-02T20:56:48.868845-05:00 [ERROR] RPC request GetStagedText failed: buffer has no file

And similarly here are some logs from the remote server at ~/.local/share/zed/logs/server-workspace-10.log:

❯ cat ~/.local/share/zed/logs/server-workspace-10.log | tail -n 7
{"level":1,"module_path":"project","file":"crates/project/src/lsp_store.rs","line":5621,"message":"(remote server) content modified"}
{"level":1,"module_path":"remote::ssh_session","file":"crates/remote/src/ssh_session.rs","line":2181,"message":"(remote server) server:unhandled ssh message name:RenameProjectEntry"}
{"level":1,"module_path":"remote::ssh_session","file":"crates/remote/src/ssh_session.rs","line":2181,"message":"(remote server) server:unhandled ssh message name:RenameProjectEntry"}
{"level":1,"module_path":"remote::ssh_session","file":"crates/remote/src/ssh_session.rs","line":2181,"message":"(remote server) server:unhandled ssh message name:RenameProjectEntry"}
{"level":1,"module_path":"lsp","file":"crates/lsp/src/lsp.rs","line":863,"message":"(remote server) oneshot canceled"}
{"level":1,"module_path":"project","file":"crates/project/src/lsp_store.rs","line":5621,"message":"(remote server) oneshot canceled"}
{"level":1,"module_path":"project","file":"crates/project/src/lsp_store.rs","line":5621,"message":"(remote server) oneshot canceled"}
@AlJohri AlJohri added admin read bug [core label] labels Jan 3, 2025
@JosephTLyons JosephTLyons added git Git integration feedback project panel Feedback for files tree view and removed triage labels Jan 3, 2025
@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Jan 3, 2025

Huh, this is a strange one - I'm not able to reproduce it on my end, so I'm wondering what the difference might be.

For Zed teammates - I noticed git is indicating that that is a new file, so I added the git tag - no idea if that's playing a role here or not.

@PharrellWANG
Copy link

Same issue here. File renaming in File Explorer is not working as expected in remote session.

@epsilam
Copy link

epsilam commented Jan 13, 2025

+1, exact same problem (Zed open in remote session, and the bug presents itself in the exact same way as in @AlJohri 's video).
Running Zed v0.168.2 on Ubuntu 22.04. Hope this gets fixed soon.

@aborg-dev
Copy link
Contributor

I believe this is a duplicate of #22883 that should be fixed by #23382 in the next Zed release.

@AlexDaichendt
Copy link

It is still broken on v0.170.2.

@aborg-dev
Copy link
Contributor

It is still broken on v0.170.2.

Indeed! The fix was only released in v0.171.0 for now: https://zed.dev/releases/preview/0.171.0

So you either need to switch to Preview version or wait until the change makes it to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] git Git integration feedback project panel Feedback for files tree view
Projects
None yet
Development

No branches or pull requests

7 participants