Wrap AnyView.cached_style in an Rc to make the struct much smaller
#22640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
changed the title
AnyView.cached_style in an Rc to make clone efficientAnyView.cached_style in an Rc to make clone more efficient
Byte size before was 672, now is 56
mgsloan
force-pushed
the
wrap-cached-style-in-rc
branch
from
faa2d4f to
fc650f8
Compare
mgsloan
changed the title
AnyView.cached_style in an Rc to make clone more efficientAnyView.cached_style in an Rc to make the struct much smaller
|
Planning to revisit this after #22632 is merged |
auto-merge was automatically disabled
January 4, 2025 07:51
Pull request was closed
|
Merged this in #24363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte size before was 672, now is 56
Release Notes: