LSP-based formatting does not use snapshots to ensure edits are applied correctly

[mgsloan]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

With the changes in #22929 the behavior is to resolve anchors to points in the current buffer snapshot. This is an improvement over the state before, where these points were computed in editor.rs.

There are two ways snapshots should be used here:

• To know the point ranges to send to the LSP.
• To apply edits from the LSP correctly.

It might not be great to rely on commutative edits here. The best thing to do might be to abort a particular selection or buffer's formatting if there are conflicts, maybe even with some limited retry.

Zed Version and System Specs

N/A

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

No response

[failable]

When I run editor: format selection on selected region, the whole buffer is formatted. Is this related?

[mgsloan]

@failable Probably unrelated. Most likely reason is because some language servers do not support formatting a selected region.