Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log an error when there are no buffer snapshots for some LSP version #22934

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 10, 2025

I'm hoping this will bring more visibility to issues related to keeping track of what version of code the LSP has:

  • I've seen diagnostic ranges not appearing in the correct places.

  • There have also been reports of edits from language servers misapplying. This might bring more visibility to the issue - it doesn't seem good to silently use the current version of the buffer.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 10, 2025
@mgsloan mgsloan enabled auto-merge January 10, 2025 00:18
@mgsloan mgsloan added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit c41b25c Jan 10, 2025
13 checks passed
@mgsloan mgsloan deleted the log-error-for-missing-lsp-buffer-snapshots branch January 10, 2025 00:48
@mrnugget
Copy link
Member

When I run this against a normal main.go file and save to format, I get this on every save:

[2025-01-10T10:02:34+01:00 ERROR project::lsp_store] No LSP snapshots found for buffer with path "main.go"

I also get this at the start with Rust files:

[2025-01-10T10:04:27+01:00 ERROR project::lsp_store] No LSP snapshots found for buffer with path "src/main.rs"
[2025-01-10T10:04:27+01:00 ERROR project] content modified
[2025-01-10T10:04:27+01:00 ERROR editor] content modified
[2025-01-10T10:04:41+01:00 ERROR project::lsp_store] No LSP snapshots found for buffer with path "src/main.rs"

Subsequent saves with Rust don't produce them though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants