Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/prev match buttons (< >) impact a different panel depending on panel focus #23906

Closed
micouy opened this issue Jan 30, 2025 · 2 comments · Fixed by #24037
Closed

Next/prev match buttons (< >) impact a different panel depending on panel focus #23906

micouy opened this issue Jan 30, 2025 · 2 comments · Fixed by #24037
Assignees
@probably-neb

Comments

@micouy
Copy link

micouy commented Jan 30, 2025

Summary

Steps to trigger the problem:

  1. Open the same file in two panels.
  2. Search for different things in each of them.
  3. Put cursor in panel 1.
  4. Click on < or > in the search in panel 2.

Actual Behavior:

Cursor goes to the next match in panel 1.

Expected Behavior:

Cursor goes to the next match in panel 2.

Zed Version and System Specs

Zed: v0.170.4 (Zed)
OS: macOS 15.1.0
Memory: 128 GiB
Architecture: aarch64
@probably-neb probably-neb self-assigned this Jan 30, 2025
@probably-neb probably-neb mentioned this issue Jan 31, 2025
Merged
probably-neb added a commit that referenced this issue Jan 31, 2025
@probably-neb
Ensure pane where search buttons are clicked is focused before dispat…
027fe1b 
…ching action (#24037)

Closes #23906

Note: Changes the focused pane when search UI is interacted with on an
unfocused pane rather than leaving the focused pane unchanged as
focusing on click is more likely to be the expected behavior

Release Notes:

- Fixes an issue with search actions so that they now execute on the
clicked pane rather than the focused pane when using search UI in
multiple panes
@probably-neb
Copy link
Contributor

This should be fixed in the next release of Zed. Please open a new issue and let us know if it isn't!

@micouy
Copy link
Author

micouy commented Feb 1, 2025

awesome, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@probably-neb probably-neb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure pane where search buttons are clicked is focused before dispatching action zed-industries/zed
2 participants
@probably-neb @micouy