Revert recent anti-aliasing improvements #24289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31fa414.
cla-bot
bot
added
the
cla-signed
|
This is can't revert, because MSAA need this. Unless that, the path draw will have a unexpected cross line. |
|
If this is just a wavy line problem, maybe you can try to solve it. |
|
Thank you for the addition, will revert that too. It would be great to have this back, though, I loved the image difference overall. |
This reverts commit b9e0aae.
SomeoneToIgnore
changed the title
PathBuilder based on lyon to build Path (#22808)"
|
/cherry-pick v0.173.x |
|
OK, until there is a new repair solution, I can temporarily extract it and use it first. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
This reverts commit 31fa414. This reverts commit b9e0aae. `lyon` commit revert:  `MSAA` commit revert:  cc @huacnlee , @\as-cii had decided to revert this PR due to a selection right corner rendering bug. Not sure what to propose for a fix from my side Release Notes: - N/A
|
No rush, we are bumping versions today hence will ship the old version, and starting tomorrow we have the entire week to test whatever. |
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 5, 2025
Cherry-picked Revert recent anti-aliasing improvements (#24289) This reverts commit 31fa414. This reverts commit b9e0aae. `lyon` commit revert:  `MSAA` commit revert:  Release Notes: - N/A Co-authored-by: Kirill Bulatov <[email protected]>
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
Feb 5, 2025
This reverts commit 31fa414. This reverts commit b9e0aae. `lyon` commit revert:  `MSAA` commit revert:  cc @huacnlee , @\as-cii had decided to revert this PR due to a selection right corner rendering bug. Not sure what to propose for a fix from my side Release Notes: - N/A
Is this issue (Red arrow)? |
|
I got it.
After fix
|
huacnlee
added a commit
to huacnlee/zed
that referenced
this pull request
Feb 6, 2025
This reverts commit aaf432f.
huacnlee
added a commit
to huacnlee/zed
that referenced
this pull request
Feb 6, 2025
This reverts commit aaf432f.
|
Yeah, that was the one. |
SomeoneToIgnore
pushed a commit
that referenced
this pull request
Feb 6, 2025
…lection top right corner radius issue (#24342) Release Notes: - N/A ---- To fix #24289 mention issue and revert PathBuilder and MSAA. I'm sorry about of this, in #22808 I was forgotten this bit of detail.  So, add `move_to` here, we can fix the selection top right corner radius issue. ## After change <img width="1383" alt="image" src="https://github.com/user-attachments/assets/28ea103c-d652-41d6-bbe0-7fd042d81e77" />
maxdeviant
added a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 31fa414.
This reverts commit b9e0aae.
lyoncommit revert:MSAAcommit revert:cc @huacnlee , @\as-cii had decided to revert this PR due to a selection right corner rendering bug.
Not sure what to propose for a fix from my side
Release Notes: