Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpui: Add data table example #24373

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Feb 6, 2025

Release Notes:

  • N/A

As #24260 I mentioned issue.

Make a complex data table example to test the text rendering performance.

This example also can be an example to show how to build a large data table.

cargo run -p gpui --example data_table
image

I will try to do some test.

For example: With a threshold for the hold number of caches in FrameCache, and only when the threshold is greater than a certain number, some caches are released, or when a certain time has passed. I am not sure if this is feasible.

This example is added to help us to test.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 6, 2025
@huacnlee huacnlee marked this pull request as draft February 6, 2025 11:35
@Angelk90
Copy link
Contributor

Angelk90 commented Feb 6, 2025

@huacnlee : You can post the complete example seen in the video of #24260.

@mikayla-maki mikayla-maki marked this pull request as ready for review February 7, 2025 02:45
@mikayla-maki mikayla-maki marked this pull request as draft February 7, 2025 02:45
@mikayla-maki
Copy link
Contributor

This looks like a cool example!

@huacnlee huacnlee marked this pull request as ready for review February 7, 2025 07:48
@huacnlee huacnlee changed the title gpui: Add data table example for measure too many text render performance gpui: Add data table example Feb 7, 2025
@mikayla-maki mikayla-maki merged commit ead5a83 into zed-industries:main Feb 7, 2025
12 checks passed
@huacnlee huacnlee deleted the cache-more-texts branch February 9, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants