-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube playlists #1
Comments
This will be non-trivial: http://stackoverflow.com/questions/23286808/youtube-iframe-api-fails-load-or-cue-playlist |
I think it's 100% we are going to use plyr. We have a PR for incorporating plyr. |
@apoorvnandan This sounds like a great approach! We're currently working on getting plyr support in #153. |
I'll start with some mocks till #153 gets merged. From what I read on plyr's documentation, playlists is in the "planned development" section so we will have to display our own list. |
@apoorvnandan We might start by adding playlist support to Plyr, then work on integrating playlist functionality here once #153 is done. Does that make sense? Ping @sampotts: what's your take on this? What can we do to help move sampotts/plyr#3 along? |
Yeah that makes sense. I would like to help in adding playlist support to Plyr too. |
When we get around to this, we may want to use OAuth so users can listen to their private playlists (including watch later) |
FYI @apoorvnandan we've added plyr support now. If you're going to do this, don't worry about the UI at all. Leave a comment on the plyr issue as well when/if you start on this: sampotts/plyr#3 |
The plyr player looks great. I have my final exams going on so I'll start the work after four days. |
@apoorvnandan sounds like a plan, good luck with exams! |
@apoorvnandan are you still interested in doing this? 😃 |
Yes, I'm interested! :) |
@apoorvnandan I see. maybe we should implement it without Plyr. We might be waiting for a very long time otherwise.
I think this should be an option, not sure what the right default value would be. This is basically just the native autoplay feature for YouTube. I'm curious if it "just works" if we call |
I'll check it out and see if it works. |
Are there some restrictions associated with our Youtube API Key? I get the following response.
|
You need to make the request from a web server. If you add a jquery get to everything.js and log the output you can run npm start then look in the browser console. |
@apoorvnandan ping 😃 |
@shakeelmohamed I'm so so sorry for the late response. I actually had the playlist URLs working fine about 2 weeks ago but I did not give an update here as I wanted to check the code for bugs and also clean it up (remove all the console.logs :) ) Shall I open a PR to discuss the changes I have made? |
@apoorvnandan please do! |
Merge 'master' from original repository
If anybody is looking to implement this, https://codepen.io/onigetoc/pen/veWNbP is a good starting point for how to load and parse the playlist. I made a PR (#336 ) based on that code, and I think it wouldn't be that hard to also add in playlists to the playlist I created on PR #336 . |
Things to investigate:
The text was updated successfully, but these errors were encountered: