-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeat track does not repeat when clicking towards end of song #327
Comments
@shakeelmohamed I have started working on this... |
@vandanmshah Please look at my PR #328 first and see if it's fixed. I think it's been solved, but it just hasn't been really tested yet. |
@k----n Checked your fix and i am not sure this will work because actually the problem is once you end the player explicitly it loses the |
@vandanmshah Okay, I see what you mean. I added something for the 'ended' EventListener and enabled/disabled plyr's 'loop' option, and it seems to sort of fix it. I feel like some of the code isn't needed though... What's not working now is that when you try to reproduce this bug, the play/pause doesn't update sometimes. Let me know how your fix goes, interested in knowing what the outcome is! |
@k----n Okay i also did same thing now this will work you can carry on with this fix... I am closing my PR... Thanks... |
@k----n I will look into it if you want? |
@vandanmshah Please do! I haven't really looked into why the play/pause button doesn't update. Maybe submit a PR to my branch? https://github.com/k----n/zen-audio-player.github.io/tree/repeat-fix |
Is this still an issue? It only seems to happen if you fast forward to the very last second of the file at the moment. Was this always the issue? |
@SimonRosengren I guess that's the bug, it only happens when clicking near the end of the track. can you help test #328? |
Bug/issue:
The text was updated successfully, but these errors were encountered: