You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some class names generated on rendered exhibit elements are extremely specific, e.g exhibit-tabularView-body and exhibit-thumbnailView-itemContainer . This will make it hard to e.g. change one's mind about which view to use without also going back and changing css. I think it would help to use more generic classnames, e.g. exhibit-viewBody and exhibit-itemContainer, to be used in addition to or instead of the more specific classes (note that if for example the containing view received class exhibit-thumbnailView, then instead of exhibit-thumbnailView-itemContainer I could use the selector exhibit-thumbnailView > exhibit-itemContainer).
If this issue is accepted/approved then I will keep in mind to make such changes as I do other work on the code.
The text was updated successfully, but these errors were encountered:
I think that the selectors there are complex enough.
It might be an interesting idea to have an attribute to add site-specific classes to the table. Guess one can do that with the tableStyler, oth that's a pretty big sword for that purpose.
Some class names generated on rendered exhibit elements are extremely specific, e.g exhibit-tabularView-body and exhibit-thumbnailView-itemContainer . This will make it hard to e.g. change one's mind about which view to use without also going back and changing css. I think it would help to use more generic classnames, e.g. exhibit-viewBody and exhibit-itemContainer, to be used in addition to or instead of the more specific classes (note that if for example the containing view received class exhibit-thumbnailView, then instead of exhibit-thumbnailView-itemContainer I could use the selector exhibit-thumbnailView > exhibit-itemContainer).
If this issue is accepted/approved then I will keep in mind to make such changes as I do other work on the code.
The text was updated successfully, but these errors were encountered: