Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and grouping are incorrect #86

Open
zepheiryan opened this issue Sep 26, 2012 · 1 comment
Open

Sorting and grouping are incorrect #86

zepheiryan opened this issue Sep 26, 2012 · 1 comment
Assignees
Milestone

Comments

@zepheiryan
Copy link
Member

As discovered in #55, there is a bug surrounding sorting and grouping. Taking the Nobelists demo as a sample, multiple sorts will start to show some sub-groups as children of their sibling order instead of siblings, and some sub-groups will simply be missing. The algorithm for generating these does not appear to be entirely correct.

Note that the changes that temporarily fixed #55 should be backed out once this is repaired; they will be unnecessary.

@ghost ghost assigned zepheiryan Sep 26, 2012
@zepheiryan
Copy link
Member Author

This change is too aggressive given the default on ordered views is to use grouping. Anybody sorting by label is going to get something of a surprise with this change. Backing out d3e1f08 and going back to the fix used in #55 for now. A better solution probably involves using a hybrid, keeping things as they are when only one level of sorting is used, breaking out one item as a group behavior when more than one level of sorting is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant