From 2dadbfc37d53aa3bef97ad32ef76114a0393050d Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 6 Dec 2024 11:57:58 -0500 Subject: [PATCH 1/8] fail on error --- .clang-tidy | 2 +- .github/workflows/clang_tidy.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index ee49cf5a1..9cd5e9c54 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -9,7 +9,7 @@ Checks: performance-*, -performance-avoid-endl ' -WarningsAsErrors: '' +WarningsAsErrors: '*' HeaderFilterRegex: '' UseColor: true FormatStyle: 'file' diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 82b4b4795..58a128566 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -62,4 +62,4 @@ jobs: - name: Run Clang Tidy working-directory: ice-demos/cpp run: | - find . -name "*.h" -o -name "*.cpp" | xargs run-clang-tidy-18 -j$(nproc) -quiet + run-clang-tidy-18 -j$(nproc) -quiet From 955936b79711e5fb8389c7873ba3506b8c9caf44 Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 6 Dec 2024 14:20:10 -0500 Subject: [PATCH 2/8] clang-tidy 19 --- .github/workflows/clang_tidy.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 58a128566..176fda771 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -17,10 +17,10 @@ jobs: # This LLVM script will add the relevant LLVM PPA: https://apt.llvm.org/ wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh chmod +x /tmp/llvm.sh - sudo /tmp/llvm.sh 18 - sudo apt-get install -y clang-tidy-18 + sudo /tmp/llvm.sh 20 + sudo apt-get install -y clang-tidy-19 rm /tmp/llvm.sh - clang-tidy-18 --version + clang-tidy-19 --version - name: Install bear run: | @@ -62,4 +62,4 @@ jobs: - name: Run Clang Tidy working-directory: ice-demos/cpp run: | - run-clang-tidy-18 -j$(nproc) -quiet + run-clang-tidy-19 -j$(nproc) -quiet From ead54545d552ccba255706234d340981dab974cc Mon Sep 17 00:00:00 2001 From: Joe George Date: Fri, 6 Dec 2024 14:25:41 -0500 Subject: [PATCH 3/8] clang-tidy 20 --- .github/workflows/clang_tidy.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 176fda771..81d13b7a6 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -18,9 +18,9 @@ jobs: wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh chmod +x /tmp/llvm.sh sudo /tmp/llvm.sh 20 - sudo apt-get install -y clang-tidy-19 + sudo apt-get install -y clang-tidy-20 rm /tmp/llvm.sh - clang-tidy-19 --version + clang-tidy-20 --version - name: Install bear run: | @@ -62,4 +62,4 @@ jobs: - name: Run Clang Tidy working-directory: ice-demos/cpp run: | - run-clang-tidy-19 -j$(nproc) -quiet + run-clang-tidy-20 -j$(nproc) -quiet From f3de845a1976a725cbc1c8fbebbfd1dc922a00df Mon Sep 17 00:00:00 2001 From: Joe George Date: Tue, 10 Dec 2024 11:10:18 -0500 Subject: [PATCH 4/8] reformat CheckOptions --- .clang-tidy | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 9cd5e9c54..6861e706e 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -14,6 +14,5 @@ HeaderFilterRegex: '' UseColor: true FormatStyle: 'file' CheckOptions: - - { key: modernize-use-nullptr.NullMacros, value: 'NULL' } - # std::exception_ptr is a cheap to copy, pointer-like type; we pass it by value all the time. - - { key: performance-unnecessary-value-param.AllowedTypes, value: 'std::exception_ptr' } + modernize-use-nullptr.NullMacros: 'NULL' + performance-unnecessary-value-param.AllowedTypes: 'std::exception_ptr' From 9b2d74736a60e67c24cfd2e5f78fae19c1ccb6c3 Mon Sep 17 00:00:00 2001 From: Joe George Date: Tue, 10 Dec 2024 11:45:29 -0500 Subject: [PATCH 5/8] clang tidy 19 --- .github/workflows/clang_tidy.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 81d13b7a6..7bc301a07 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -17,10 +17,10 @@ jobs: # This LLVM script will add the relevant LLVM PPA: https://apt.llvm.org/ wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh chmod +x /tmp/llvm.sh - sudo /tmp/llvm.sh 20 - sudo apt-get install -y clang-tidy-20 + sudo /tmp/llvm.sh 19 + sudo apt-get install -y clang-tidy-19 rm /tmp/llvm.sh - clang-tidy-20 --version + clang-tidy-19 --version - name: Install bear run: | @@ -62,4 +62,4 @@ jobs: - name: Run Clang Tidy working-directory: ice-demos/cpp run: | - run-clang-tidy-20 -j$(nproc) -quiet + run-clang-tidy-19 -j$(nproc) -quiet -enable-check-profile From 0e9a9f52a0d5b68a397336d965fdd95f3f40a57f Mon Sep 17 00:00:00 2001 From: Joe George Date: Tue, 10 Dec 2024 12:03:01 -0500 Subject: [PATCH 6/8] fix --- .clang-tidy | 1 + .github/workflows/clang_tidy.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 6861e706e..fdec927a1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -15,4 +15,5 @@ UseColor: true FormatStyle: 'file' CheckOptions: modernize-use-nullptr.NullMacros: 'NULL' + # std::exception_ptr is a cheap to copy, pointer-like type; we pass it by value all the time. performance-unnecessary-value-param.AllowedTypes: 'std::exception_ptr' diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 7bc301a07..90405a471 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -62,4 +62,4 @@ jobs: - name: Run Clang Tidy working-directory: ice-demos/cpp run: | - run-clang-tidy-19 -j$(nproc) -quiet -enable-check-profile + run-clang-tidy-19 -j$(nproc) -quiet From 63391427f8e0a56648abfe880c87d6fd77f11760 Mon Sep 17 00:00:00 2001 From: Joe George Date: Tue, 10 Dec 2024 13:50:08 -0500 Subject: [PATCH 7/8] try :: --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index fdec927a1..6f7880d6f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -16,4 +16,4 @@ FormatStyle: 'file' CheckOptions: modernize-use-nullptr.NullMacros: 'NULL' # std::exception_ptr is a cheap to copy, pointer-like type; we pass it by value all the time. - performance-unnecessary-value-param.AllowedTypes: 'std::exception_ptr' + performance-unnecessary-value-param.AllowedTypes: '::std::exception_ptr' From 757e58e04f7e1c090aae3b25d639c0e6cf10c2c7 Mon Sep 17 00:00:00 2001 From: Joe George Date: Tue, 10 Dec 2024 15:59:37 -0500 Subject: [PATCH 8/8] testing --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 6f7880d6f..19e42e069 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -16,4 +16,4 @@ FormatStyle: 'file' CheckOptions: modernize-use-nullptr.NullMacros: 'NULL' # std::exception_ptr is a cheap to copy, pointer-like type; we pass it by value all the time. - performance-unnecessary-value-param.AllowedTypes: '::std::exception_ptr' + performance-unnecessary-value-param.AllowedTypes: 'exception_ptr$;'