Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding Media Element plugins? #9

Open
timstallmann opened this issue Jul 13, 2020 · 0 comments
Open

Allow adding Media Element plugins? #9

timstallmann opened this issue Jul 13, 2020 · 0 comments

Comments

@timstallmann
Copy link

Hi! I'm using this plugin on an Omeka site where we'd like to add some additional Media Element plugins. I've managed to make this work on my end by:

  • Adding the plugin CSS & JS in my own custom Omeka plugin via hook_public_head and hook_admin_head.
  • Extending Html5Media plugin to add an extra Custom mediaplayer settings config option which passes text into the JS configuration object for the mediaplayer element.

I'd love to submit a PR for some of this functionality but wondering what the best approach would be? I could just submit a PR for the Custom mediaplayer settings` config option, but I wonder if it might be more usable for less tech-savvy folks to add a "Media Player plugins" config section where users could toggle on and off different plugins?

Look forward to hearing your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant