Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enviroment variables updates #100

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dinxsh
Copy link
Collaborator

@dinxsh dinxsh commented Nov 27, 2024

What Type of Change is this?

  • New Page
  • Minor Fix
  • Minor Improvement
  • Major Improvement

Description (required)

several changes to environment variables across pages

@nermalcat69 nermalcat69 marked this pull request as ready for review November 28, 2024 13:39
@nermalcat69 nermalcat69 added the 🌱 Review me Add this label whenever you need a review label Nov 28, 2024
Copy link
Contributor

@vankovap vankovap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the runtime services copy Node.js changes to all others so that it's the same (and also some runtimes are missing now)

@@ -53,26 +53,57 @@ It is always necessary to redeploy your application when updating or creating en

## Setting secret variables

Use secret variables to store passwords, tokens and other sensitive information that shouldn't be part of your repository and listed in zerops.yml.
There are several ways to set secret variables to your project/services using Zerops GUI:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say only ".. to your services ..". (Project envs work a bit differently and they will be documented in a separate page later)

Also, it is possible to import a service both in this dialog and also with a zcli command, so the sentence could finish with "..to your services."

Use secret variables to store passwords, tokens and other sensitive information that shouldn't be part of your repository and listed in zerops.yml.
There are several ways to set secret variables to your project/services using Zerops GUI:

### With Import Dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said above, it's not just the dialog, but also with a zcli command, so the title could be something more general. You can add a mention about the zcli to the sentence below.

S3_ACCESS_SECRET: 'ogFthuiLYki8XoL73opSCQ'
```

### From Project > Services > Secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather say e.g. "In the service detail", it is used throughout the docs.


To edit an environment variable, click on the menu <svg xmlns="http://www.w3.org/2000/svg" style={{ marginBottom: -5 + 'px' }} height="24px" viewBox="0 -960 960 960" width="24px" fill="#e8eaed"><path d="M480-160q-33 0-56.5-23.5T400-240q0-33 23.5-56.5T480-320q33 0 56.5 23.5T560-240q0 33-23.5 56.5T480-160Zm0-240q-33 0-56.5-23.5T400-480q0-33 23.5-56.5T480-560q33 0 56.5 23.5T560-480q0 33-23.5 56.5T480-400Zm0-240q-33 0-56.5-23.5T400-720q0-33 23.5-56.5T480-800q33 0 56.5 23.5T560-720q0 33-23.5 56.5T480-640Z"/></svg> on the right side of its row.
1. To add a single individual variable, click the `Add secret variable` button and set values for `Key` and `Value`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to discord please update titles and buttons/sections references in this file

@@ -195,3 +207,24 @@ You can use runtime env variables in the build environment using the `RUNTIME_`
If you create a secret env variable and a basic runtime env variable with the same key, Zerops saves the basic runtime env variable from your zerops.yml and ignores the secret env variable.

If you create a basic build env variable and a runtime env variable with the same key, Zerops saves both because the build and runtime environments have separate sets of env variables.

## Setting secret variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take only line 217 - 226 and add them to line 83 with a title ### Set secret env variables when importing a service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Review me Add this label whenever you need a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants