Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localnet-based automated tests #231

Open
fadeev opened this issue Mar 3, 2025 · 0 comments
Open

Add Localnet-based automated tests #231

fadeev opened this issue Mar 3, 2025 · 0 comments
Labels

Comments

@fadeev
Copy link
Member

fadeev commented Mar 3, 2025

  • on each PR in the toolkit repo we clone example-contracts
  • build and link the toolkit
  • cd example-contracts/examples/call && yarn link @zetachain/toolkit
  • run localnet.sh

This way we wouldn't have to duplicate any testing logic (the same localnet sh script is used) and will test both if toolkit works and how example will work with the changes introduced in the toolkit.

One thing to consider. When making breaking changes to the toolkit, the automated tests will fail, because they're using main branch of example-contracts. Let's say a toolkit PR introduced a different set of arguments for evm-call, main branch of example contracts will fail, because they'll be using the pre-PR syntax. It is important to handle this scenario, perhaps, by passing a commit hash of a corresponding PR in example-contracts repo.

@fadeev fadeev added the ci label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant