Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Binary stream support on multiplexed ws #324

Open
AdamMagaluk opened this issue Sep 21, 2016 · 2 comments
Open

Proposal: Binary stream support on multiplexed ws #324

AdamMagaluk opened this issue Sep 21, 2016 · 2 comments

Comments

@AdamMagaluk
Copy link
Collaborator

Currently binary streams are not available on multiplexed ws.

My proposal is to allow subscriptions to binary streams and have the data returned as the data field as a base64 string per chunk received. Data queries wouldn't be applied. Limits could either be applied per chunk (could be ambiguous) or applied to data length. eg give me 1kb then stop.

Eg.

{
  "type": "event",
  "topic": "Detroit/camera/a5cb1a72-c3e7-47b6-818d-6d81b16e9ed4/video-feed",
  "subscriptionId": 1,
  "timestamp": 1442944840135,
  "data": "ewogICJhcHBOYW1lIZW5kbGUiOiAiLi9hcHAvbWFpbi1idWlsZC50cyIKfQ=="
}
@mdobson
Copy link
Contributor

mdobson commented Sep 21, 2016

  • Would there be a size limit per data field?
  • Would there be syntax to ask for things in megabytes, kilobytes, and bytes?

Other than those questions 👍

@AdamMagaluk
Copy link
Collaborator Author

  1. I don't think so.
  2. I don't think that's necessary, the 1kb was just an example. I assume you would represent it as bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants