-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wish to add another xml_node::traverse function meber #77
Comments
I don't understand the use case. Why can't you check this condition inside your for_each implementation? |
Case 1: When the function "for_each" return false , all traverse ended; |
Ah, right. Yeah, this makes sense. Unfortunately, I can't easily change the existing interface because of binary compatibility issues. The interface has some other problems as well (e.g. https://code.google.com/p/pugixml/issues/detail?id=219) that warrant changing it though, so maybe it's necessary to introduce a new interface at this point and deprecate the old one. |
Haha, I think so too. |
Closing in favor of #103, which has several different options and thoughts on the matter. |
at present, the xml_node::traverse function:
...
if (!walker.for_each(arg_for_each))
return false;
...
But, sometimes, I want to use it like this:
...
if (walker.for_each(arg_for_each) && cur.first_child())
{
// traverse it's child tree
}
else
...
The text was updated successfully, but these errors were encountered: