Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Min-Max normalization code #2

Open
Sithara85 opened this issue Nov 14, 2022 · 0 comments
Open

Issue with Min-Max normalization code #2

Sithara85 opened this issue Nov 14, 2022 · 0 comments

Comments

@Sithara85
Copy link

Hi Dr. Zhang,

I have been using some of your GitHub code to process RNAseq data and to build the VAE classifier model. I noticed that you have used the below code for MIn-Max normalization.
# Normalize the dataframe to the range of 0-1
if norm_0_1:
# Min-max normalization
data_df = (data_df - data_df.min().min()) / (data_df.max().max() - data_df.min().min())

I think you have to use data_df = (data_df - data_df.min()) / (data_df.max() - data_df.min()) to obtain matching values to sklearn.preprocessing.MinMaxScaler() function. Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant