Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #14
i considered a 'shell' attrset that had the per-shell enabled stuff in that, but decided to start simpler. there's at least one example like this in nixpkgs for the 'foot' program.
https://github.com/NixOS/nixpkgs/blob/ee8bdf4f09fdb4809ff8f2202decbfd02450edc3/nixos/modules/programs/foot/default.nix#L83
i left the integration enabled by default for all 3 main shell programs. i figure it's more common to want the commands that not.
i also considered that the content of
brew shellenv
could easily be generated from the prefix and other info already within the module.If you would prefer that route I can rework this, I think as-is does work fine though and it aligns with some homebrew instructions.
per homebrew docs, homebrew stuff is installed in front of the existing nix path which should prevent brew programs from failing in strange ways.
Example content of my brew shellenv command output:
Definitely could generate this ourselves if we wanted.
I'm not sure if manpath and infopath are correct for nix.
testing done: i opened each shell and saw that 'cowsay' was accessible.