Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etld/fsm.go triggers pathological compiler case #1

Open
rogpeppe opened this issue Jul 18, 2016 · 1 comment
Open

etld/fsm.go triggers pathological compiler case #1

rogpeppe opened this issue Jul 18, 2016 · 1 comment

Comments

@rogpeppe
Copy link

I tried to compile it under Go 1.7rc1 and the compiler never
completed.

See golang/go#16407 - there's a suggestion
by @josharian for a possible way to work around the issue
in fsm.go code.
thanm added a commit to thanm/xparse that referenced this issue Jul 20, 2016
@thanm
Emit fsm code in chunks as opposed single func.
64d06af 
Changes genfsm.go to divide the state space into chunks
of size 256, then call a helper for function for each
chunk (as opposed to having a single giant function that
does everything). This reduces the compile time for go1.7
down to something reasonable (15-30 seconds depending on
machine speed). See related issues

zhenjl#1
golang/go#16407
@thanm thanm mentioned this issue Jul 20, 2016
Open
@zhenjl
Copy link
Owner

zhenjl commented Oct 6, 2016

It seems like the latest go 1.7.1 was able to finish the compilation:

time go test

PASS
ok github.com/zhenjl/xparse/etld 0.014s

real 2m10.354s
user 1m50.362s
sys 0m2.138s

Not great since it's still 2 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogpeppe @zhenjl