New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md - Examples -undefined+unused variables #11

Open

Kulatymic opened this issue Jul 20, 2020 · 1 comment

Kulatymic commented Jul 20, 2020 •

edited

Loading

In Readme.md Examples:

//$this is not defined
$request = new SaleRequest($transactionID, $this->parser->parse('10.5', 'EUR'));

//$money are unused
$money = new Money(1, new Currency('USD'));

//example should rather be?
$money = new Money(1, new Currency('USD'));
$request = new SaleRequest($transactionID, $money);

The text was updated successfully, but these errors were encountered:

mifzp-dev commented Aug 27, 2020

It seems to be already fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment