Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes zigs
json.parseFromSlice
return errorUnexpectedToken
when trying to parse a 'numbered string' when expecting an integer. For example the below test succeeds and parses "2134071" to an i32, while I believe that it should fail since the type of "number" is a json string.Both Rust's Serde and Go's json are stricter and fail when trying to parse json 'numbered strings' to numbers and this would make zigs json lib conform to the expected behaviour of those other languages libs and make it up to the user to then parse the string to a number.