std.meta.eql: use == directly when comparing packed structs
#21982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nitpicking on the comment, as a a non-native speaker I find "on a field-by-field basis" easier to understand than "field-wise". You are also missing a space before the last sentence (might be a good time for a tiny correction since only 2/10 CI runs finished) |
|
@Atomk, I agree with the criticism, I changed the doc comment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
std.meta.eqlupdated to reflect the changes made by #21678. This is a breaking change as floats contained withinpacked structs are now compared bitwise (this might be a reason to reject this pull request).