Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme #72

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

update readme #72

wants to merge 2 commits into from

Conversation

ala-mode
Copy link
Contributor

fixes #69

@ala-mode ala-mode requested a review from nachog00 January 25, 2025 17:12
nachog00
nachog00 requested changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@nachog00 nachog00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with the content changes.

However, this leaves lib.rs docs outdated.

I would apply this content changes there, then run ./utils/generate_readme.sh

@ala-mode
Copy link
Contributor Author

However, this leaves lib.rs docs outdated.

I would apply this content changes there, then run ./utils/generate_readme.sh

Okay, I thought this might be the case because we're autogenerating readmes. I might try this soon, or you could if this hangs too long.

@ala-mode ala-mode requested a review from nachog00 January 26, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachog00 nachog00 Awaiting requested review from nachog00

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update README
2 participants
@ala-mode @nachog00