From 9cddaeb56e044ab05e3131916b39848c56e92a0f Mon Sep 17 00:00:00 2001 From: Erik van Oosten Date: Sat, 16 Nov 2024 12:27:54 +0100 Subject: [PATCH] Remove 'experimental' label from `FetchStrategy` (#1393) The `FetchStrategy` trait has not seen any change since its introduction over a year ago. It is time to remove the experimental label. --- docs/consumer-tuning.md | 3 +-- .../src/main/scala/zio/kafka/consumer/ConsumerSettings.scala | 3 --- .../main/scala/zio/kafka/consumer/fetch/FetchStrategy.scala | 2 -- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/docs/consumer-tuning.md b/docs/consumer-tuning.md index 625e5c336..374d30b27 100644 --- a/docs/consumer-tuning.md +++ b/docs/consumer-tuning.md @@ -57,8 +57,7 @@ the partition queues. A very rough estimate for the maximum amount of heap neede The total can be tuned by changing the `partitionPreFetchBufferLimit`, `max.poll.records` settings. Another option is to write a custom `FetchStrategy`. For example the `ManyPartitionsQueueSizeBasedFetchStrategy` in -[draft PR 970](https://github.com/zio/zio-kafka/pull/970) (merged into zio-kafka since 2.8.1). Note that the fetch strategy API is marked as -experimental and may change without notice in any future zio-kafka version. +[draft PR 970](https://github.com/zio/zio-kafka/pull/970) (merged into zio-kafka since 2.8.1). ## Long processing durations diff --git a/zio-kafka/src/main/scala/zio/kafka/consumer/ConsumerSettings.scala b/zio-kafka/src/main/scala/zio/kafka/consumer/ConsumerSettings.scala index e5e63771f..20325fd02 100644 --- a/zio-kafka/src/main/scala/zio/kafka/consumer/ConsumerSettings.scala +++ b/zio-kafka/src/main/scala/zio/kafka/consumer/ConsumerSettings.scala @@ -284,9 +284,6 @@ final case class ConsumerSettings( withPartitionPreFetchBufferLimit(partitionPreFetchBufferLimit) /** - * WARNING: [[zio.kafka.consumer.fetch.FetchStrategy]] is an EXPERIMENTAL API and may change in an incompatible way - * without notice in any zio-kafka version. - * * @param fetchStrategy * The fetch strategy which selects which partitions can fetch data in the next poll. The default is to use the * [[zio.kafka.consumer.fetch.QueueSizeBasedFetchStrategy]] with a `partitionPreFetchBufferLimit` parameter of 1024, diff --git a/zio-kafka/src/main/scala/zio/kafka/consumer/fetch/FetchStrategy.scala b/zio-kafka/src/main/scala/zio/kafka/consumer/fetch/FetchStrategy.scala index e8098fac0..2cd5d6e39 100644 --- a/zio-kafka/src/main/scala/zio/kafka/consumer/fetch/FetchStrategy.scala +++ b/zio-kafka/src/main/scala/zio/kafka/consumer/fetch/FetchStrategy.scala @@ -8,8 +8,6 @@ import scala.collection.mutable /** * A fetch strategy determined which stream are allowed to fetch data in the next poll. - * - * WARNING: this is an EXPERIMENTAL API and may change in an incompatible way without notice in any zio-kafka version. */ trait FetchStrategy {