Benchmark history cleanup #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do the benchmarks still run on PR branches or did we remove that and it runs just on master? |
This PR only removes the results of old PR benchmarks. For the rest I did not change anything. So when benchmarks are running is still the same. As far as I know PR benchmarks are still running. |
|
BTW, this is a low risk change. If it doesn't work, we can simply revert and all the data is back! 🙂 |
Also: remove data for one more `JMHSample_01_HelloWorld.wellHelloThere` benchmark
Removing these because this branch causes such a huge peak in the graph that the rest of the graph became less readable.
Benchmarks `zio.kafka.bench.ConsumersComparisonBenchmark.*` were moved to another package. By renaming the old data, these data points are joined again in the same graphs.
erikvanoosten
force-pushed
the
benchmark-history-cleanup
branch
from
643b37c to
edc41ce
Compare
|
I merged because:
Before: After: |
|
One more correction in 24e7382 we get:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of commits that each clean up a part of the benchmark history:
JMHSample_01_HelloWorld.wellHelloTherebenchmarkZioKafkaNoOptimisticResumeBenchmarksbenchmark (plus one moreJMHSample_01_HelloWorld.wellHelloThere)ZioKafkaNoPrefetchingBenchmarksNew commit interfacebranch to get rid of the high peak in the graphszio.kafka.bench.ConsumersComparisonBenchmark.*were moved to another package. By renaming the old data, these data points are joined again in the same graphs.The last step was done with a bash script and can be repeated regularly. Documentation for that will follow in a later PR.