Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run checks on auto PRs #245

Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore: run checks on auto PRs #245

merged 1 commit into from
Aug 30, 2024

Conversation

eliobischof
Copy link
Member

Checks for PRs created automatically using the GITHUB_TOKEN secret are pending forever. This prevents merging these PRs.
PRs created using a GitHub App token can trigger other workflows needed for their checks.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Aug 30, 2024
@eliobischof eliobischof merged commit c4ebcb1 into main Aug 30, 2024
10 checks passed
@eliobischof eliobischof deleted the run-auto-pr-checks branch August 30, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliobischof @stebenz