-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmchart revamp #262
base: main
Are you sure you want to change the base?
Helmchart revamp #262
Conversation
https://github.com/gruntwork-io/terratest/tree/master/examples/helm-dependency-example Current build issues are regarding dependancies being missing (makes sense seeing as this is the first time dependancies are even in this). but something seems to be missing in the test to pull those dependancies, gonna scour the tests, see if i cant find it |
looks like the tests are expecting every pod declared even if the dependancy is optional 😪 |
Looks like your missing BuildDependancies from the tests, is that intentional? |
@Lite5h4dow we decided to push the idea of using subcharts with the cert job to the backlog for now. There are pros and cons, and we'd like to figure out a good solution. Is it ok for you to keep the PR open as a draft, so we can pick it up again? I think it will not be too far in the future. |
Definition of Ready
There are quite a few changes here, so I'm going to list them.
postgresql.enabled
andcockroachdb.enabled
they are mutually exclusive and the template with throw a fit if you enable both. (actually that might need moving out of the certjob template....) also, they are both disabled by default, so nothing should change for user deployments if they did it with a separate chart before.