Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simple API tests to ensure consistency of API #27

Open
ziyadedher opened this issue Nov 26, 2019 · 0 comments
Open

Create simple API tests to ensure consistency of API #27

ziyadedher opened this issue Nov 26, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ziyadedher
Copy link
Owner

Is your feature request related to a problem? Please describe.
We rely very heavily on mypy to verify that our APIs follow the described contracts; however, given that mypy is not a heavily enforced type-checker and it cannot catch runtime errors such as tensor size mismatches, we should rely on some runtime tests to verify any changes.

Describe the solution you'd like
Use a framework such as pytest with coverage to verify our code is valid. This might involve writing tests for each type of actor/critic/agent and testing them in different environments, but given the modularity of our system, that should not be too difficult to automate.

@ziyadedher ziyadedher added the enhancement New feature or request label Nov 26, 2019
@ziyadedher ziyadedher self-assigned this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant