From c288e90ce2b9084215c122edd717d5b1ce851b12 Mon Sep 17 00:00:00 2001 From: zkbenny Date: Mon, 6 May 2024 13:42:08 +0800 Subject: [PATCH] fix: abdk_audit_6_cvf_4 --- contracts/ZkLink.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contracts/ZkLink.sol b/contracts/ZkLink.sol index 993258c..8330088 100644 --- a/contracts/ZkLink.sol +++ b/contracts/ZkLink.sol @@ -494,6 +494,8 @@ contract ZkLink is uint256 _toBatchNumber, bytes32[] calldata _l2LogsRootHashes ) external onlyValidator { + // The first open or the next open + require(totalBatchesExecuted == 0 || _fromBatchNumber == totalBatchesExecuted + 1, "Invalid open"); require(_toBatchNumber >= _fromBatchNumber, "Invalid range"); bytes32 range = keccak256(abi.encodePacked(_fromBatchNumber, _toBatchNumber)); bytes32 rangeBatchRootHash = rangeBatchRootHashes[range]; @@ -511,9 +513,7 @@ contract ZkLink is } require(_rangeBatchRootHash == rangeBatchRootHash, "Incorrect root hash"); delete rangeBatchRootHashes[range]; - if (_toBatchNumber > totalBatchesExecuted) { - totalBatchesExecuted = _toBatchNumber; - } + totalBatchesExecuted = _toBatchNumber; emit OpenRangeBatchRoot(_fromBatchNumber, _toBatchNumber); }