Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a couple of potentially useful mappings #48

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

swflint
Copy link
Contributor

@swflint swflint commented Dec 20, 2024

Following #43, and to fulfill my initial request in #41 (and to a lesser extent #42), this PR adds a couple of mappings.

It adds:

  • a mapping for Denote
  • a mapping for PDF metadata

@swflint swflint mentioned this pull request Dec 20, 2024
@swflint swflint force-pushed the add-optional-mappings branch from 71db5d1 to a035076 Compare December 20, 2024 02:54
@swflint swflint force-pushed the add-optional-mappings branch from 7eb8a30 to 739df83 Compare December 20, 2024 04:06
@zkry zkry changed the base branch from main to implement-mappings December 20, 2024 21:07
@zkry
Copy link
Owner

zkry commented Dec 20, 2024

Thanks for these, they look great and will make a great addition! I'll merge this, test everything, and release it with the rest of the mapping features.

As always, if any part is confusing when implementing definitely let me know and I'll try to get it changed before the 1.0 release.

I also definitely have on my backlog cleaning up the main p-search.el code to make it easier to understand and modify.

@zkry zkry merged commit 3c94449 into zkry:implement-mappings Dec 20, 2024
@swflint swflint deleted the add-optional-mappings branch December 22, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants