Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse comments with github-flavoured-markdown #7

Open
michaelficarra opened this issue May 11, 2012 · 7 comments
Open

parse comments with github-flavoured-markdown #7

michaelficarra opened this issue May 11, 2012 · 7 comments

Comments

@michaelficarra
Copy link

All the comments (and issue text, and probably others) look ugly because they're not being formatted the way they were intended.

@zmoazeni
Copy link
Owner

I don't think I'll implement this. I don't know of any GFM javascript libraries and I don't know if I want to maintain one. If you find one, please pass it along.

@zmoazeni
Copy link
Owner

I saw that and:

GitHub now has previews on all inputs that use GFM. This live preview should be considered deprecated. It may not render exactly the same way github.com will due to differences in markdown libraries.

@michaelficarra
Copy link
Author

Even better! In that case, just have the user's browser "preview" each comment to render it. Just POST to https://github.com/preview with the proper text and repository values. It should return the HTML that you can use to replace the markdown. You can even do it lazily as they enter the viewport.

@zmoazeni zmoazeni reopened this May 11, 2012
@zmoazeni
Copy link
Owner

Oooh. That may work nicely. I may toy with that.

@michaelficarra
Copy link
Author

Oooh, it even accepts requests using GET: https://github.com/preview?text=Awesome!%20%237&repository=4257391

@tkazec
Copy link

tkazec commented May 16, 2012

There's also marked, which is extremely fast, compliant, implements GFM, and works on both node and the client side: https://github.com/chjj/marked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants