Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish and Completion order #70

Open
zompi2 opened this issue Jan 22, 2025 · 0 comments
Open

Finish and Completion order #70

zompi2 opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zompi2
Copy link
Owner

zompi2 commented Jan 22, 2025

Currently every action runs completion events first and then marks the action as finished.
This can lead to a confusing situation, where developer would like to modify the action in the completion event right before it becames invalid.
Logically, in the completion event the action should be marked as finished. It shouldn't be allowed to pause/resume/reset such action at this point.

Please pay attention to what happens when action is finished via RemoveAction with bComplete set to true.

@zompi2 zompi2 added the bug Something isn't working label Jan 22, 2025
@zompi2 zompi2 self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant