Add missing decoder case for NaN #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieka
force-pushed
the
add-nan-decoder-case
branch
from
0a9a5dd to
79a2413
Compare
danieka
force-pushed
the
add-nan-decoder-case
branch
from
79a2413 to
dc8c291
Compare
|
This is interesting. Could you provide the version of the MongoDB? The only different is, that the sign bit is set to 1. |
|
Thank you! |
|
@zookzook We use MongoDB 7.3.3 Enterprise, but this could also be related to the library we use for writing to Mongo, but I don't know what we use there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running against our Mongo instance we got the following error:
Turns out that, at least for our Mongo installation, this case is used for NaN. I have validated that the value is NaN in Mongo Compass and adding this case results in the document being deserialised to the same values as in Compass.