Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to drop Python 2.7 up to 3.6 support. #179

Merged
merged 13 commits into from
Dec 23, 2022
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 20, 2022

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good, I started trying it.
But two inline comments: one stray double quote, and the pyupgrade call does not work for me: likely a difference between Mac and Linux that I can't figure out.

config/drop-legacy-python.py Outdated Show resolved Hide resolved
config/drop-legacy-python.py Outdated Show resolved Hide resolved
@dataflake
Copy link
Member

I will not be using this script because it gives me no control over what gets committed during its run. At least config_package.py provides ways to say "don't commit anything, I want to control changes manually". One run against Zope right now ended up with changes I don't want, all committed and ready for push so that I deleted the entire clone and started from scratch.

@dataflake dataflake linked an issue Dec 21, 2022 that may be closed by this pull request
@dataflake
Copy link
Member

I added a switch for an "interactive" mode that will allow scripts to prompt for input and prevents automatic commits and pushes.

@icemac
Copy link
Member Author

icemac commented Dec 23, 2022

It seems time to merge this PR. Thank you for working on it.

@icemac icemac merged commit b274912 into master Dec 23, 2022
@icemac icemac deleted the drop-legacy-python.py branch December 23, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 runs twice for zope-product config ?
4 participants