-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to drop Python 2.7 up to 3.6 support. #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good, I started trying it.
But two inline comments: one stray double quote, and the pyupgrade call does not work for me: likely a difference between Mac and Linux that I can't figure out.
Co-authored-by: Maurits van Rees <[email protected]>
And it is confusing to keep it.
I will not be using this script because it gives me no control over what gets committed during its run. At least config_package.py provides ways to say "don't commit anything, I want to control changes manually". One run against Zope right now ended up with changes I don't want, all committed and ready for push so that I deleted the entire clone and started from scratch. |
I added a switch for an "interactive" mode that will allow scripts to prompt for input and prevents automatic commits and pushes. |
It seems time to merge this PR. Thank you for working on it. |
Used to create: