Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with manylinux aarch64 for Python 3.13 #240

Closed
dataflake opened this issue May 18, 2024 · 1 comment · Fixed by #242
Closed

Issues with manylinux aarch64 for Python 3.13 #240

dataflake opened this issue May 18, 2024 · 1 comment · Fixed by #242
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@dataflake
Copy link
Member

Testing Python 3.13-based wheels on manylinux/aarch64 currently fails, see https://github.com/zopefoundation/zope.interface/actions/runs/9102178342/job/25021162232.

Looking at the output the first thing I am wondering about is why aarch64 is handled differently in the .manylinux-install.sh script. Unlike other platforms it explicitly installs tox and runs the tox tests:

        if [ `uname -m` == 'aarch64' ]; then
          cd /io/
          ${PYBIN}/pip install tox
          TOXENV=$(tox_env_map "${PYBIN}")
          ${PYBIN}/tox -e ${TOXENV}
          cd ..
        fi

Is that because none of us can really test Linux/aarch64 locally?

Secondly, this fails on Python 3.13. (side note: the script should be more fault-tolerant and not fail entirely when one build/test fails)

Unlike earlier Python versions, Python 3.13 actually has two different interpreters on those manylinux2014 images that are both tested by the script, one a standard compile with GIL, the other free-threaded with no GIL because that's a new feature for 3.13. The non-GIL version fails during the zope.interface wheel installation for testing claiming the wheel is not compatible with the running architecture. The wheel actually builds fine in a preceding step.

I am wondering if the script should skip the no-GIL version. I have no idea how a free-threaded version would interact with any of our packages.

@dataflake dataflake added help wanted Extra attention is needed question Further information is requested labels May 18, 2024
@icemac
Copy link
Member

icemac commented May 22, 2024

+1 from me to not test no-GIL Python now. See zopefoundation/zope.interface#297 for the changes which are necessary to port that package to be able to run on no-GIL - this is way beyond my C knowledge.

Regarding the tests: Linux is tested in the Ubuntu jobs but not for aarch64, so it is tested separately in its manylinux job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants