Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix 'tox -e coverage' for 'c-code' projects #272

Closed
wants to merge 1 commit into from

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented Aug 27, 2024

Closes #271.

@tseaver tseaver requested review from icemac and dataflake August 27, 2024 16:19
@tseaver tseaver enabled auto-merge August 27, 2024 16:22
@dataflake
Copy link
Member

I am unhappy about turning this back on for all projects. I have not seen this coverage failure in other c-code projects. I wonder if there's a specific reason why the coverage data is not found (or not written).

@tseaver tseaver disabled auto-merge August 27, 2024 16:36
@tseaver
Copy link
Member Author

tseaver commented Aug 27, 2024

Perhaps there is something just weird about persistent? tox -re coverage works on the master of BTrees (which has that commit applied) and on the config-with-c-code-template-4eec7859 branch of zope.i18nmessageid (which applies it).

@dataflake
Copy link
Member

I'll try to spend some time on that tomorrow. There has to be a way to get this working for persistent without usedevelop. It works for other similar packages as well.

@dataflake
Copy link
Member

A little research has shown that this is not a common issue for c-code projects. It affected persistent because that uses custom coverage configurations that don't work (anymore). This is fixed in zopefoundation/persistent@149c88e. The test failures on Windows are unrelated, those come from yet another setuptools incompatibility and I will fix that within the configuration template.

@dataflake dataflake closed this Aug 28, 2024
@dataflake dataflake deleted the tseaver-271-fix_coverage_under_tox branch August 28, 2024 07:47
@tseaver
Copy link
Member Author

tseaver commented Aug 28, 2024

@dataflake Thanks for figuring that out! I broke my brain on it yesterday.

@tseaver
Copy link
Member Author

tseaver commented Aug 28, 2024

@dataflake I spoke a little too soon: tox -re coverage still fails the same way in persistent on master after the change you applied in 149c88e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox -re coverage b0rken for c-code projects
2 participants