Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PURE_PYTHON environment variable set to 0 #71

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

perrinjerome
Copy link
Contributor

@perrinjerome perrinjerome commented Sep 30, 2024

Setting to 0 should be equivalent to not setting the variable.

Closes zopefoundation/meta#283

@perrinjerome
Copy link
Contributor Author

tests are failing, because this depends on a new release of zope.security including zopefoundation/zope.security#115

@perrinjerome
Copy link
Contributor Author

The situation is like this:

  • zope.proxy depends on zope.security , but only for the test. With these changes, zope.proxy tests only pass with the next version of zope.security
  • zope.security depends on zope.proxy. zope.security with Respect PURE_PYTHON environment variable set to 0 zope.security#115 require these changes, otherwise it does not work when the environment variable PURE_PYTHON is set to 0.

The sequence of actions can be:

  1. we merge these changes. For this we need to to pass, so I introduced a new commit to use zope.proxy from git ( a5a03e6 )
  2. we make a new release of zope.proxy ( 6.1 ). At this point the tests from Respect PURE_PYTHON environment variable set to 0 zope.security#115 should pass
  3. we revert a5a03e6
  4. we change zope.security to depend on zope.proxy >= 6.1

Would that make sense ? can I proceed with merging this with the tox.ini change ?

@dataflake
Copy link
Member

If the choice is "make a release of package X, which is ready for release" and "grab package X from git to make this work" then I would always choose the first solution. Is there any reason not to just make a zope.security release?

@dataflake
Copy link
Member

If the choice is "make a release of package X, which is ready for release" and "grab package X from git to make this work" then I would always choose the first solution. Is there any reason not to just make a zope.security release?

zope.proxy release I mean? I am getting confused by these circular dependencies.

@dataflake
Copy link
Member

I would NOT add that git dependency in tox.ini and simply schedule releases of zope.proxy and zope.security at about the same time. No one cares if test fail during that small time window in between. If you need help merging PRs despite failing tests let me know.

@perrinjerome perrinjerome force-pushed the perrinjerome/PURE_PYTHON branch from a5a03e6 to 62c4a3b Compare October 2, 2024 12:29
@perrinjerome
Copy link
Contributor Author

Thank you @dataflake I did not consider this option, but it's much easier if we can merge the two pull requests regardless of the test status.

I dropped the tox change, so if we can "force" a merge with the current state, I think it's OK. I don't have the option to merge from github web interface, so if you can help it's highly welcome.

@dataflake dataflake merged commit c09d699 into master Oct 2, 2024
95 of 104 checks passed
@dataflake dataflake deleted the perrinjerome/PURE_PYTHON branch October 2, 2024 13:19
@dataflake
Copy link
Member

Let me know if you need me to make releases

@dataflake
Copy link
Member

@perrinjerome
Copy link
Contributor Author

Thank you @dataflake yes these are the expected failures at this point, there does not seem to be more problems.

If you can make releases for these two packages it would repair the tests.

PS: I'm sorry this needed so much work from you guys, it seemed like a very small change when it started.

@dataflake
Copy link
Member

dataflake commented Oct 2, 2024

Everything looks good now, as the last step I am re-running the failed GHA run for zope.security on tag 7.3 hoping it will then upload the still-missing ARM64 wheels to PyPI. The tests are passing there now.

@dataflake
Copy link
Member

All wheels are now uploaded.

@perrinjerome
Copy link
Contributor Author

Thank you @dataflake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question on usage of PURE_PYTHON
3 participants